search

Phidica / sublime-fish

A robust Sublime Text syntax package for fish
MIT License
35 stars 2 forks source link

"end" at the end of file is not highlighted correctly #15

Closed vvolhejn closed 6 years ago

vvolhejn commented 6 years ago

Consider the code

if true
end

(without a newline after end). Then end is highlighted as if it were a command name rather than a keyword; in Monokai, blue instead of red.

In other syntax highlighters (try the same code highlighted like MATLAB), this behaves as expected.

Phidica commented 6 years ago

Ah, thank you for pointing this out. I use ST with the "ensure_newline_at_eof_on_save" setting enabled, so I hadn't noticed this. The syntax almost exclusively looks for \n to end scopes, rather than $ which is all that would be present at the end of the file... I'll take a look

vvolhejn commented 6 years ago

Thanks! I have newline-on-save as well, but it was a bit annoying before saving.

On Sun, 17 Jun 2018, 15:19 Violet, notifications@github.com wrote:

Closed #15 https://github.com/Phidica/sublime-fish/issues/15 via 29382f5 https://github.com/Phidica/sublime-fish/commit/29382f5022d202e83d3c877cf41893cc6a0a6324 .

— You are receiving this because you authored the thread. Reply to this email directly, view it on GitHub https://github.com/Phidica/sublime-fish/issues/15#event-1684977340, or mute the thread https://github.com/notifications/unsubscribe-auth/AIAy2PqOjeKOM5EV_1aXXdutZL_LEJ9Uks5t9ldzgaJpZM4UqcV7 .