search

Phidica / sublime-fish

A robust Sublime Text syntax package for fish
MIT License
35 stars 2 forks source link

conflicts with default shell script syntax #18

Closed nhooyr closed 5 years ago

nhooyr commented 6 years ago

See https://github.com/sublimehq/Packages/blob/289782ff2e4cb58de171579c7fc86fe00d280619/ShellScript/Bash.sublime-syntax#L16

Not sure if there is a way to make this plugin override that as the default everywhere.

rwols commented 6 years ago

Hi Anmol, that file extension existed in the syntax from way back. However, the default shell script syntax does not support fish anymore. Maybe you can make a pull request to remove it?

nhooyr commented 6 years ago

Will do.

nhooyr commented 6 years ago

See https://github.com/sublimehq/Packages/pull/1664

Phidica commented 6 years ago

Thanks for submitting the upstream pull request. I'll close this issue if it gets accepted otherwise we can return to the original question of making this package override

Phidica commented 5 years ago

I just noticed that PR was merged, so I believe that closes this issue