search

Phidica / sublime-fish

A robust Sublime Text syntax package for fish
MIT License
35 stars 2 forks source link

Allow "fish_directory" setting to accept a multi-platform dictionary #26

Closed eugenesvk closed 3 years ago

eugenesvk commented 3 years ago

It's common in Sublime Text for various path settings to accept dictionaries with per-platform paths to be able to have a single config file for various platforms, so this PR allows to do the same in the fish plugin

I've added the corresponding changelog/message items, but not sure it's worth a separate release, so might be better to change the number/file name to the actual release number whatever that might be

Phidica commented 3 years ago

Thank you for the contribution! I never considered this use case but it definitely makes sense to allow it and do so in this way.

I agree that it probably doesn't warrant a solo release, so it will likely be bundled into 3.3.0 instead when I get around to making that. fish 3.3 didn't make any relevant changes to the syntax, so our 3.3.0 release will be another quiet release mostly for the sake of keeping in line with the fish version numbers, like 3.2.0 was. I'll probably hold off on that a little bit longer in case anything else comes up.

Phidica commented 2 years ago

Sooooo I forgot about this 🤦‍♀️ Sorry! But it is finally out now as part of 3.4.0 :)