search

Phidica / sublime-fish

A robust Sublime Text syntax package for fish
MIT License
35 stars 2 forks source link

Highlight issue #3

Closed dnicolson closed 7 years ago

dnicolson commented 7 years ago

The following code results the last end being highlighted the full width of the document:

function my_func
  begin
    echo "hi"
  end; or begin
    echo "hi again"
  end
end
screen shot 2017-08-14 at 16 09 27
Phidica commented 7 years ago

Hi! Thanks for the report. I suspect this issue stems from a continuing problem I've had with properly treating begin ... end as a sort of grouped command which could appear anywhere a normal command could. I've been thinking of solutions, and I believe I have one for this bug, but I've been a little too busy lately to work on this project. I'll try and find some time soon to work through this and other matters in #2

Phidica commented 7 years ago

Actually it was a little easier than I'd thought. But it happened because I have been drawing a distinction between blocks and command calls, even though the former is an instance of the latter. I will probably revise this at some point