Phidica / sublime-fish

A robust Sublime Text syntax package for fish
MIT License
35 stars 2 forks source link

Make the base scope `source.shell.fish`, in order to get the new shell build system to work with it #9

Closed rwols closed 6 years ago

rwols commented 6 years ago

If the base scope is source.shell.fish, the ShellScript.sublime-build can pick it up and then we can run our fish scripts from within sublime with cmdB.

Phidica commented 6 years ago

I'm not sure I understand you. Are you saying that the base scope should be made this? Because it already is (since 79802e6). That being said, wouldn't it make more sense for this package to provide its own version of sublime-build rather than depend on ShellScript to provide it? I would be happy to include a build system with the package

rwols commented 6 years ago

You're totally right, I haven't pulled from the master branch in a while.

That being said, wouldn't it make more sense for this package to provide its own version of sublime-build rather than depend on ShellScript to provide it?

I specifically made that build system so that it would also work with zsh, tcsh, fish, etc.