search

PhilBroderick / SportBoard

0 stars 0 forks source link

Notify users when a request is closed. #16

Closed PhilBroderick closed 5 years ago

PhilBroderick commented 5 years ago

Users have the functionality to open requests and look at requests in their user history - but it would be nice to notify users when a request is either accepted or denied, along with a reason and the admin who responded. Might be good to split the deletion requests off into their own section for users instead of having it in the user history section.

PhilBroderick commented 5 years ago

PR #35 starts to implement this. Still need to display all notifications and unread to a user and decide how I want it to be displayed. Feed deletions responses and new comments need added also.

PhilBroderick commented 5 years ago

Once a notification system is complete I will have a MVP that can be seen as complete in the first instance.

PhilBroderick commented 5 years ago

PRs #36, #37 & #38 mostly implement this feature. Still need to figure out how to let users 'read' notifications so they become read. Add filter options for read vs unread and need to add something to the nav bar to let users know they have new/unread notifications.

PhilBroderick commented 5 years ago

PR #41 allows users to mark notifications as read. Need to add a selection to show all notifications or just unread as it is currently only unread, so it'll disappear after being clicked. Also can now implement notification number on nav bar as I have JS files working in partial views.

PhilBroderick commented 5 years ago

PR #42 adds a selection for users to choose to view read notifications as well as unread. Nav bar also displays correct unread notification count.

PhilBroderick commented 5 years ago

Feature has been fully implemented - will close off. This also meets the MVP of the product.