search

PhilBroderick / SportBoard

0 stars 0 forks source link

User request to remove a feed they created. #2

Open PhilBroderick opened 5 years ago

PhilBroderick commented 5 years ago

Currently no one can delete a feed. There should be some functionality added that allows users to request a feed they created be deleted. This would then be visible on an administrators dashboard as a request to which they can either allow or deny. The functionality would then be needed for an administrator to delete a feed.

PhilBroderick commented 5 years ago

In conjunction to this, having notifications on a user profile would be handy. There should be a notification sent to the user who requested the deletion whether it was accepted or not.

PhilBroderick commented 5 years ago

Commits c6dd5b1ba0db93e53289595c576403cf5878bdf8, 9b0bcdea7a510127a1ef067830f8eec5fbea4c4a, ec830a5db98eba051bd7bad44a609e3f7e3de979 now start to implement this feature.

PhilBroderick commented 5 years ago

Still need to add a text field to allow admins to give a reasoning behind why they deleted or didn't delete the request. The 'Yes' link doesn't actually delete the feed yet - needs implemented. There is currently no functionality to allow a user who created a feed to request a deletion - might be good to have an extra tab for them to view their requests/support tickets and check activity.

PhilBroderick commented 5 years ago

In order to remove a feed, as there is a foreign key to the deletion request, both will be deleted, however I do not want to remove deletion requests. This brings up the thought of whether it is right to delete feeds also or just archive until a later date - will think through this. Leaning towards archive into another table though.

PhilBroderick commented 5 years ago

Deletion requests can be made by users however the redirect is incorrect - f15544f754e4fca03d406b51db1d8101590e466d

PhilBroderick commented 5 years ago

In relation to this, a deletion request can be approved - and the deletion request table updates accordingly. However, the feed is still viewable on the index, and even if not could be viewed by going directly to the Url - need to check for this.

PhilBroderick commented 5 years ago

079a7e64b5b79e2ba123e1f31999219335ab4afe allows only active feeds to be pulled back to controllers/views. However users could still navigate directly to a URL of a 'deleted' feed so need to check for this on the Details Action.

PhilBroderick commented 5 years ago

PR #15 adds an admin response to the deletion requests. Still need to check if the prompt is empty (not allowed). Think it might be more user friendly to have an input box pop up instead of the default prompt box.

PhilBroderick commented 5 years ago

Going to leave this open as there is still stuff to be ironed out as per comments above. However will open new enhancement for sending the users a notification when a request is either accepted or rejected.