search

PhilKes / NotallyX

Minimalistic Android note taking App | Notally, but eXtended.
GNU General Public License v3.0
70 stars 1 forks source link

Actions like pin/label/archive only work from overview, not individual note/list #124

Closed maxstarkenburg closed 6 days ago

maxstarkenburg commented 1 week ago

What happened?

When I'm on an individual note or list, if I try to pin it, archive it, or label it from there, none of those actions seem to work. The label might temporarily appear, but doesn't seem to "stick" once going back to the overview.

All these actions seem to work fine if I select the note/list from the overview page and perform it from there.

App Version

v6.1.1

Android Version

14

(Optional) Relevant log output

No response

PhilKes commented 6 days ago

That bug is most surely introduced by #88 which saves the note only if there is a change that can be undone in the ChangeHistory, but clearly this is not sufficient since adding a label to a note is not pushed to the ChangeHistory. I will rework this, so that it saves the note if any field of BaseNote differs from the note when it was initially opened, which then also includes pinned, labels, etc.

maxstarkenburg commented 1 day ago

Thank you, got the latest version and indeed this all seems fixed. Thanks for such great responsiveness!