Unneeded Notification Permission on Image Upload

[CodeNomadHQ]

When adding an image, it requests notification permissions even though they aren't necessary

https://github.com/user-attachments/assets/930fdbfd-0a3f-4c30-9d8a-66b3c5bdaf98

[PhilKes]

I was wondering about that too, it originates from: https://github.com/PhilKes/NotallyX/commit/f7d26072607c1f4de1801c030d8f84a65271f124

https://github.com/PhilKes/NotallyX/blob/f7d26072607c1f4de1801c030d8f84a65271f124/app/src/main/res/values/strings.xml#L145 The thing is if we remove the request permission dialog her, we would have to move it to when a user tries to delete an image/file, because as the text states a notification is shown when multiple files/images are deleted

[CodeNomadHQ]

In that case, maybe we can start with a popup for notification permissions when the app first opens. It would explain the reason upfront and make things cleaner than what we have now.

[PhilKes]

In that case, maybe we can start with a popup for notification permissions when the app first opens. It would explain the reason upfront and make things cleaner than what we have now.

Mh I think most people dont like being asked for permissions for features they might not even use. I personally havent yet used the feature to add images/files myself, what we could do instead is move asking for the permission to the actions that really require it, importing backups or deleting files

[CodeNomadHQ]

Haven't thought about it that way. Yeah, it makes more sense to ask for permissions only when they’re really needed, just like you said.

[PhilKes]

@CodeNomadHQ So I had a look again, the only places where a Notification is shown is when recording audio, and when File/Images are deleted. To be honest I think in both cases we dont need any notification:

1. Recording Audio: The notification is only used to show if the app is ready to record and while recording, but I think that adds no real benefit since 1. when you are recording you are inside the NotallyX App, so why would you need a notification? And 2. Android automatically shows a green Microphone icon in the status bar when you use the microphone:

With Notification:

notallyx_issues_34_with_notification.webm

Without Notification:

notallyx_issues_34_without_notification.webm

2. Deleting Files/Images: I cant even showcase this because the deletion is too fast. Also deleting files is not something that automatically runs in the background, the user explicitely deletes Notes and its files via the UI, so I dont see any benefit of a notification:

notallyx_issues_34_clear_data_with_notification.webm

Instead I would just show a progress dialog as usual:

notallyx_issues_34_clear_data_with_progressdialog.webm

Like this we wouldnt need the Notification permission at all, so I think that is the best solution. If we have some need to show statusbar notifications we can just re-add it again.

[CodeNomadHQ]

I didn’t realize that recording audio required notification permission; I assumed it worked like the camera app. so yeah, makes sense to remove that part. anyway Great job on this