PhilMurwin / growl-for-windows

Automatically exported from code.google.com/p/growl-for-windows
0 stars 0 forks source link

Growl.Connector does not work with mono on unix systems #48

Open GoogleCodeExporter opened 9 years ago

GoogleCodeExporter commented 9 years ago
What steps will reproduce the problem?
1. Modify the test app to send notifications to a mac or windows growl server. 
Run the test app with mono on a unix system

What is the expected output? What do you see instead?

Should see notifications, but no notifications show up.

What version of the product are you using? On what operating system?

trunk
mono
Linux and Mac

Please provide any additional information below.

GNTP requires "\r\n" as line endings, but the MessageBuilder is using 
Environment.Newline to add line endings. On Unix systems, this will be "\n", 
which is incorrect. The following diff fixes the bug:

Index: MessageBuilder.cs
===================================================================
--- MessageBuilder.cs   (revision 137)
+++ MessageBuilder.cs   (working copy)
@@ -194,7 +194,7 @@
         /// <summary>
         /// Byte array containing the bytes the represent a blank line
         /// </summary>
-        protected static readonly byte[] blankLineBytes = 
GetStringBytes(Environment.NewLine);
+        protected static readonly byte[] blankLineBytes = 
GetStringBytes("\r\n");

         /// <summary>
         /// The bytes of the section

Original issue reported on code.google.com by fhri...@gmail.com on 8 Aug 2014 at 3:12