search

PhilWaldmann / openrecord

Make ORMs great again!
https://openrecord.js.org
MIT License
486 stars 38 forks source link

Oracle support #37

Closed devleaks closed 7 years ago

devleaks commented 7 years ago

Would it be difficult to add/include Oracle's RDBMS support through node-oracledb? Apparently, Oracle is already supported in Knex. Thank you.

PhilWaldmann commented 7 years ago

It's not very difficult. Just take a look at the postgres implementation: https://github.com/PhilWaldmann/openrecord/tree/master/lib/stores/postgres

devleaks commented 7 years ago

OK, thanks. I indeed copy/pasted from mysql, and adjusted a few things and it worked. Thanks. P.

PhilWaldmann commented 7 years ago

Do you mind creating a PR with your changes?!

devleaks commented 7 years ago

Well, I just copied lib/stores/mysql to lib/stores/oracle, adjusted the connection parameters, and adjusted a few simplified types, which were not necessary to me (select queries only). Unfortunately I chose to not continue with openrecords and npm uninstalled it. So that was deleted. P.

PhilWaldmann commented 7 years ago

Allright ;)