search

PhilWaldmann / openrecord

Make ORMs great again!
https://openrecord.js.org
MIT License
486 stars 38 forks source link

.prettierrc is missing #67

Closed firede closed 6 years ago

firede commented 6 years ago

I noticed that .eslintrc.js extends prettier rules.

https://github.com/PhilWaldmann/openrecord/blob/f2eb0e8ad42919cc8bf88f9f064e991cce1b2c67/.eslintrc.js#L5-L8

But it doesn't seem to have the .prettierrc, this caused some extra spaces at the end of the line, e.g.

https://github.com/PhilWaldmann/openrecord/blob/f2eb0e8ad42919cc8bf88f9f064e991cce1b2c67/lib/stores/sqlite3/autoload.js#L14

Add the missing .prettierrc configuration and a commit hook to format it, that would be nice 🌟

PhilWaldmann commented 6 years ago

Thanks @firede

firede commented 6 years ago

👍 @PhilWaldmann

There is a small problem:

https://github.com/PhilWaldmann/openrecord/blob/a104825faff093ae311951d9c18e1a4669792078/package.json#L42-L47

You probably need to move lint-staged to devDependencies.

PhilWaldmann commented 6 years ago

@firede You are right, my fault!

PhilWaldmann commented 6 years ago

fixed with 2.0.3