search

PhilanthropyDataCommons / auth

PDC related extensions that were made for the keycloak auth service
1 stars 1 forks source link

On first login, "phone number" was missing a space #25

Closed bickelj closed 1 year ago

bickelj commented 1 year ago

When entering a mobile number, there might be a space missing in phone number or mobile number.

bickelj commented 1 year ago

I see it here

Fork and fix will be needed, or perhaps more dirtily, unjar and rejar with that message changed.

bickelj commented 1 year ago

I sent this idea upstream as well.

bickelj commented 1 year ago

Draft of change looks like this locally: image

bickelj commented 1 year ago

26 works with keycloak 20.0.5 but not with 21.0.2. We are still on 20.0.5 in production, so we will need to change the dependency versions in modules here and test the changes with 21.x when upgrading.

bickelj commented 1 year ago

It worked in the test environment, sending to prod.

The change is to build the new required action jar and set the appropriate env var in /home/deploy/.env.

bickelj commented 1 year ago

Better: image

kfogel commented 1 year ago

I sent this idea upstream as well.

@bickelj Any particular reason you did that as a discussion rather than as a PR? This seems like a pretty straightforward typo fix.

kfogel commented 1 year ago

I sent this idea upstream as well.

@bickelj Any particular reason you did that as a discussion rather than as a PR? This seems like a pretty straightforward typo fix.

Actually, I'll just ask that in the upstream ticket!