search

PhilanthropyDataCommons / auth

PDC related extensions that were made for the keycloak auth service
1 stars 1 forks source link

Add keycloak required action #26

Closed bickelj closed 1 year ago

bickelj commented 1 year ago

Add space to mobile number required action message

In the upstream example code, there was no space between the words "phone" and "number". This commit adds a space.

This has also been suggested upstream at https://github.com/dasniko/keycloak-extensions-demo/discussions/12

Issue #25 On first login, "phone number" was missing a space

bickelj commented 1 year ago

@jasonaowen Thanks for the speedy review and speedy-to-fix comments! I have added some more detail to the README and the fork commit.

It took more than an hour and less than two hours to do the fork, yes, but I think this will be only the first of many requested changes. So we are better positioned to make more as needed.

bickelj commented 1 year ago

@slifty informally confirmed that I had addressed @jasonaowen's requested changes.