Closed hminsky2002 closed 2 months ago
It's worth mentioning that this came out of https://github.com/PhilanthropyDataCommons/front-end/pull/748#discussion_r1710288746, because newer versions of TypeScript and/or ESLint will complain about the mix of optional fields and default values.
In
components/ProposalListTable.tsx
, we explicitly set the value for rowClickDestination, yet it is a required valueFurthermore, when we render the ProposalListTable in the ProposalListTablePanel component, we do not provide a vale for rowClickDestination (
components/ProposalListTablePanel.tsx
lines 52-62)We should instead set the rowClickDestination prop explicitly inside the ProposalListTablePanel component and remove the default values from our components.