search

PhilanthropyDataCommons / service

A project for collecting and serving public information associated with grant applications
GNU Affero General Public License v3.0
8 stars 2 forks source link

Fix auth signature test #1019

Closed slifty closed 2 months ago

slifty commented 2 months ago

This PR fixes a test that was occasionally failing in CI. It also simplifies the test so that's good!

Resolves #1009

codecov[bot] commented 2 months ago

Codecov Report

All modified and coverable lines are covered by tests :white_check_mark:

Project coverage is 88.50%. Comparing base (366a176) to head (1f9fb43). Report is 9 commits behind head on main.

Additional details and impacted files ```diff @@ Coverage Diff @@ ## main #1019 +/- ## ======================================= Coverage 88.50% 88.50% ======================================= Files 128 128 Lines 1723 1723 Branches 219 219 ======================================= Hits 1525 1525 - Misses 183 198 +15 + Partials 15 0 -15 ```

:umbrella: View full report in Codecov by Sentry.
:loudspeaker: Have feedback on the report? Share it here.

slifty commented 2 months ago

ooooo great catch -- I had run npm i incorrectly originally and then manually moved it from dependencies to devDependencies in the package.json -- I did NOT re-run npm i to update the lock file.

Fixed!

Side note: there should probably be some kind of CI catch to make sure that there are no local changes after CI has been invoked.

reefdog commented 2 months ago

there should probably be some kind of CI catch to make sure that there are no local changes after CI has been invoked.

Agreed! I was actually surprised this wasn't caught by CI.

Re-reviewing…