search

PhilanthropyDataCommons / service

A project for collecting and serving public information associated with grant applications
GNU Affero General Public License v3.0
8 stars 2 forks source link

Fix readonly object references #1020

Closed slifty closed 2 months ago

slifty commented 2 months ago

This PR fixes the way some of our object attributes are marked as readOnly so that swagger codegen will properly generate types that don't combine with any.

To test this you will need to follow the instructions in https://github.com/PhilanthropyDataCommons/sdk to use this branch's openapi.json to generate the sdk. You can search the resulting code to ensure & any is not included anywhere.

Resolves #1004

codecov[bot] commented 2 months ago

Codecov Report

All modified and coverable lines are covered by tests :white_check_mark:

Project coverage is 88.57%. Comparing base (bb5e5cc) to head (203a2f8). Report is 2 commits behind head on main.

Additional details and impacted files ```diff @@ Coverage Diff @@ ## main #1020 +/- ## ======================================= Coverage 88.57% 88.57% ======================================= Files 129 129 Lines 1724 1724 Branches 220 213 -7 ======================================= Hits 1527 1527 - Misses 182 197 +15 + Partials 15 0 -15 ```

:umbrella: View full report in Codecov by Sentry.
:loudspeaker: Have feedback on the report? Share it here.