search

PhilanthropyDataCommons / service

A project for collecting and serving public information associated with grant applications
GNU Affero General Public License v3.0
8 stars 2 forks source link

Fix `PresignedPostRequest` definition #1023

Closed slifty closed 2 months ago

slifty commented 2 months ago

This PR fixes the definition of PresignedPostRequest so that swagger codegen will honor the readonly nature of the presignedPost attribute.

This will be a breaking change to the SDK since it changes the name of the PresignedPost type (which was previously PresignedPostRequestPresignedPost.

Resolves #1012

This should be merged after:

codecov[bot] commented 2 months ago

Codecov Report

All modified and coverable lines are covered by tests :white_check_mark:

Project coverage is 88.57%. Comparing base (f986027) to head (bd3901f).

:exclamation: Current head bd3901f differs from pull request most recent head 28e4c8b

Please upload reports for the commit 28e4c8b to get more accurate results.

Additional details and impacted files ```diff @@ Coverage Diff @@ ## main #1023 +/- ## ======================================= Coverage 88.57% 88.57% ======================================= Files 129 129 Lines 1724 1724 Branches 220 220 ======================================= Hits 1527 1527 Misses 182 182 Partials 15 15 ```

:umbrella: View full report in Codecov by Sentry.
:loudspeaker: Have feedback on the report? Share it here.