Closed hminsky2002 closed 2 weeks ago
All modified and coverable lines are covered by tests :white_check_mark:
Project coverage is 88.57%. Comparing base (
625be13
) to head (3e56720
).
:umbrella: View full report in Codecov by Sentry.
:loudspeaker: Have feedback on the report? Share it here.
I believe
BaseField.ts
will need to be updated too, correct?diff --git a/src/types/BaseField.ts b/src/types/BaseField.ts index c0d9c61..6af8a4d 100644 --- a/src/types/BaseField.ts +++ b/src/types/BaseField.ts @@ -7,7 +7,7 @@ export enum BaseFieldDataType { NUMBER = 'number', PHONE_NUMBER = 'phone_number', EMAIL = 'email', - URL = 'URL', + URL = 'url', BOOLEAN = 'boolean', }
I do believe you are correct @reefdog ! Updating and force pushing now
@hminsky2002 just to confirm I don't see the change yet, unless I'm missing it!
@hminsky2002 just to confirm I don't see the change yet, unless I'm missing it!
@slifty apologies, I was running into an issue where altering the enum was failing the migration, with the error
Reason: unsafe use of new value "url" of enum type field_type
Which seems to suggest that directly altering the enum is not liked by our system? I kept the feature of making a new enum, but have been able to avoid the case statement which does feel better!
This PR remedies a typo from the field_type enum, which is used to validate the type of a basefield. The value of 'url' was originally capitalized as 'URL', but this goes against our convention. It adds a new migration, and updates the seed file accordingly. Notably, it also casts any existing base-fields with type 'URL' to 'url'
Closes #989