search

PhilanthropyDataCommons / service

A project for collecting and serving public information associated with grant applications
GNU Affero General Public License v3.0
8 stars 2 forks source link

Use DB helpers rather than queries in tests #1097

Closed slifty closed 1 month ago

slifty commented 2 months ago

This PR does the final round of updates to our code base, removing any instance of direct queries in the code / using our helpers everywhere.

This will make changes to schema easier to implement / should involve less updating of tests down the line.

And with this we can finally say...

Resolves #228

codecov[bot] commented 2 months ago

Codecov Report

All modified and coverable lines are covered by tests :white_check_mark:

Project coverage is 88.57%. Comparing base (e1635ac) to head (1ac1a56). Report is 4 commits behind head on main.

Additional details and impacted files ```diff @@ Coverage Diff @@ ## main #1097 +/- ## ======================================= Coverage 88.57% 88.57% ======================================= Files 129 129 Lines 1725 1725 Branches 220 213 -7 ======================================= Hits 1528 1528 Misses 197 197 ```

:umbrella: View full report in Codecov by Sentry.
:loudspeaker: Have feedback on the report? Share it here.

slifty commented 1 month ago

Appreciate the review (and the thoughts regarding the fact that there are some negatives / tradeoffs of this approach)

I'll merge this since it's the final step in making our code base consistent but will also highlight #331 as a place where we can take a moment to reflect on the best setup patterns overall.