search

PhilanthropyDataCommons / service

A project for collecting and serving public information associated with grant applications
GNU Affero General Public License v3.0
8 stars 2 forks source link

Add BaseField enum validation #1100

Closed slifty closed 1 month ago

slifty commented 1 month ago

This PR fixes an omission from our BaseField type definition (and resulting validation).

The API should now properly return an error code if the base field has an unexpected value.

Resolves #1099

codecov[bot] commented 1 month ago

Codecov Report

All modified and coverable lines are covered by tests :white_check_mark:

Project coverage is 88.57%. Comparing base (2000407) to head (6c88f3c).

Additional details and impacted files ```diff @@ Coverage Diff @@ ## main #1100 +/- ## ======================================= Coverage 88.57% 88.57% ======================================= Files 129 129 Lines 1725 1725 Branches 220 220 ======================================= Hits 1528 1528 Misses 182 182 Partials 15 15 ```

:umbrella: View full report in Codecov by Sentry.
:loudspeaker: Have feedback on the report? Share it here.