search

PhilanthropyDataCommons / service

A project for collecting and serving public information associated with grant applications
GNU Affero General Public License v3.0
8 stars 2 forks source link

Update application form queries #861

Closed slifty closed 5 months ago

slifty commented 5 months ago

This PR continues the work of DB consolidation and moving to a standardized way of accessing data.

It makes the following changes:

  1. Adds utility methods for create / load.
  2. Updates the existing queries into the modern age of returning json.
  3. Removes the query parameter for optionally returning deep / shallow ApplicationForms; the API now always returns deep ApplicationForms.

Related to #228

codecov[bot] commented 5 months ago

Codecov Report

Attention: Patch coverage is 90.00000% with 6 lines in your changes are missing coverage. Please review.

Project coverage is 87.00%. Comparing base (1baac30) to head (eea9b03).

:exclamation: Current head eea9b03 differs from pull request most recent head e5f7088. Consider uploading reports for the commit e5f7088 to get more accurate results

Files Patch % Lines
src/handlers/applicationFormsHandlers.ts 73.91% 5 Missing and 1 partial :warning:
Additional details and impacted files ```diff @@ Coverage Diff @@ ## main #861 +/- ## ========================================== + Coverage 86.47% 87.00% +0.52% ========================================== Files 98 101 +3 Lines 1405 1385 -20 Branches 175 166 -9 ========================================== - Hits 1215 1205 -10 + Misses 175 165 -10 Partials 15 15 ```

:umbrella: View full report in Codecov by Sentry.
:loudspeaker: Have feedback on the report? Share it here.

bickelj commented 5 months ago

I like these net-zero or net-negative PRs by the way!