search

PhilanthropyDataCommons / service

A project for collecting and serving public information associated with grant applications
GNU Affero General Public License v3.0
8 stars 2 forks source link

Fail eslint on warning #889

Closed slifty closed 7 months ago

slifty commented 7 months ago

This PR updates our lint command to fail if there are warnings. This will apply both to local invocations of lint as well as the CI invocation.

slifty commented 7 months ago

@hminsky2002 without this change I believe it will NOT fail if there are warnings, which is part of why we want to be sure this is added.

codecov[bot] commented 7 months ago

Codecov Report

All modified and coverable lines are covered by tests :white_check_mark:

Project coverage is 87.98%. Comparing base (82a07c7) to head (cb95d81). Report is 16 commits behind head on main.

:exclamation: Current head cb95d81 differs from pull request most recent head f253037. Consider uploading reports for the commit f253037 to get more accurate results

Additional details and impacted files ```diff @@ Coverage Diff @@ ## main #889 +/- ## ========================================== + Coverage 87.97% 87.98% +0.01% ========================================== Files 109 109 Lines 1488 1490 +2 Branches 182 182 ========================================== + Hits 1309 1311 +2 Misses 164 164 Partials 15 15 ```

:umbrella: View full report in Codecov by Sentry.
:loudspeaker: Have feedback on the report? Share it here.

hminsky2002 commented 7 months ago

@hminsky2002 without this change I believe it will NOT fail if there are warnings, which is part of why we want to be sure this is added.

Ah, then this is even more pertinent