search

PhilanthropyDataCommons / service

A project for collecting and serving public information associated with grant applications
GNU Affero General Public License v3.0
8 stars 2 forks source link

Update test timestamp pattern #909

Closed slifty closed 5 months ago

slifty commented 5 months ago

This PR updates our timestamp to account for situations where the DB returns lower precision timestamps, which has now happened at least once in CI!

Resolves #906

slifty commented 5 months ago

@reefdog NO!

(ok fine)

Basically the previous pattern required 3 to 6 precision points in the number of milliseconds (or NO milliseconds)

This means 2024-04-12T18:11:26.18+00:00 failed (that has .18 which is just 2 precision points)

The new regex will allow for 0 through 6 points of precision.

reefdog commented 5 months ago

@slifty Thank you! That's excellent.

reefdog commented 5 months ago

@slifty Oh my goodness, I just realized the attached issue contained the detail I needed. Apologies, and feel free in the future to just say that!

slifty commented 5 months ago

@reefdog oh no problem at all -- I probably should have included it in the commit tbh since issue / PR get detached from the code!