search

PhilanthropyDataCommons / service

A project for collecting and serving public information associated with grant applications
GNU Affero General Public License v3.0
8 stars 2 forks source link

Organizations should have a `taxId` not an `employerIdentificationNumber` #931

Closed slifty closed 6 months ago

slifty commented 6 months ago

Our organizations have an employerIdentificationNumber attribute. This was a naming mistake -- EIN is a US-specific thing whereas taxId is a more generic term and is what they use over at https://schema.org/Organization

This isn't a huge issue, but I think would be worth cleaning up sooner than later since it would be a breaking change.

slifty commented 6 months ago

cc @reefdog @hminsky2002 on this

reefdog commented 6 months ago

Agree and co-sign. This feels like a good thing to change before landing Phase 2, too.

reefdog commented 6 months ago

Do you think it's worth reframing this as a federalId or governmentId rather than tax ID? (I grok that tax ID is the correct term of art but wonder if we should go with a sort of context agnosticism / semantic appropriateness.)

slifty commented 6 months ago

@reefdog ohhh I like governmentId plenty. My only pause is that schema.org landing on taxId seems like a meaningful data point (since they're an entity that exists to think about this kind of thing). @jmergy had mentioned others in the PDC ecosystem had brought up schema.org, and so especially as we start landing on "official" attributes it might make sense to try to defer to theirs unless we have a particular reason to divert.

Thoughts on that?

reefdog commented 6 months ago

Ah, yeah, I’m down with taking hints from Schema.org. 👍

jmergy commented 6 months ago

@reefdog @slifty I do think schema dot org is a safe go-to. It has come up a few times in discussions around folks with data or not wanting to have PDC create more than necessary. There is a sense with some data that may be in play with PDC that schema dot org is something that is used as a guide in lieu of making things up.

I could also see us publishing a schema back - perhaps on bulk upload or something to contribute...