search

PhilanthropyDataCommons / service

A project for collecting and serving public information associated with grant applications
GNU Affero General Public License v3.0
8 stars 2 forks source link

Support `createdBy=me` for all endpoints that use the `createdBy` filter #961

Closed slifty closed 6 months ago

slifty commented 6 months ago

This PR lets you say createdBy=me to retrieve your own data in any instance where a createdBy parameter is accepted.

Resolves #960

codecov[bot] commented 6 months ago

Codecov Report

All modified and coverable lines are covered by tests :white_check_mark:

Project coverage is 88.23%. Comparing base (eec3d83) to head (095bbe2).

Additional details and impacted files ```diff @@ Coverage Diff @@ ## main #961 +/- ## ========================================== + Coverage 88.22% 88.23% +0.01% ========================================== Files 123 123 Lines 1707 1709 +2 Branches 210 206 -4 ========================================== + Hits 1506 1508 +2 - Misses 185 201 +16 + Partials 16 0 -16 ```

:umbrella: View full report in Codecov by Sentry.
:loudspeaker: Have feedback on the report? Share it here.

reefdog commented 6 months ago

Okay genuinely this doesn't seem to have an effect. At least, when I call /bulkUploads?createdBy=me (via front end, Swagger, cURL, whatever), it's the same as calling /bulkUploads. I get the full set either way. (And yes, the full set has uploads from multiple users. /bulkUploads?createdBy=1 returns just 10, as expected.)

slifty commented 6 months ago

Justin I didn't ask for your review yet

slifty commented 6 months ago

ok @reefdog could you please review.