search

PhilanthropyDataCommons / service

A project for collecting and serving public information associated with grant applications
GNU Affero General Public License v3.0
8 stars 2 forks source link

Add base field scope #965

Closed slifty closed 4 months ago

slifty commented 4 months ago

This PR add the concept of "scope" to base fields, which provides more meaning around whether a base field describes a proposal or the primary organization associated with a proposal.

In this PR the scope doesn't result in any change to treatment, but creating it will allow us to do things like decorate organization objects by related field values of the appropriate scope.

Resolves #917

codecov[bot] commented 4 months ago

Codecov Report

All modified and coverable lines are covered by tests :white_check_mark:

Project coverage is 88.23%. Comparing base (cf97980) to head (ac882de). Report is 4 commits behind head on main.

Additional details and impacted files ```diff @@ Coverage Diff @@ ## main #965 +/- ## ========================================== + Coverage 88.21% 88.23% +0.02% ========================================== Files 123 123 Lines 1706 1709 +3 Branches 211 206 -5 ========================================== + Hits 1505 1508 +3 - Misses 185 201 +16 + Partials 16 0 -16 ```

:umbrella: View full report in Codecov by Sentry.
:loudspeaker: Have feedback on the report? Share it here.