search

PhilanthropyDataCommons / service

A project for collecting and serving public information associated with grant applications
GNU Affero General Public License v3.0
8 stars 2 forks source link

Update some TypeScript ESLint dependencies #977

Closed bickelj closed 4 months ago

bickelj commented 4 months ago

The corresponding update from dependabot included a major ESLint version update that didn't play nicely with other ESLint deps.

codecov[bot] commented 4 months ago

Codecov Report

All modified and coverable lines are covered by tests :white_check_mark:

Project coverage is 88.72%. Comparing base (ba263cd) to head (67d7bb5). Report is 4 commits behind head on main.

Additional details and impacted files ```diff @@ Coverage Diff @@ ## main #977 +/- ## ======================================= Coverage 88.72% 88.72% ======================================= Files 127 127 Lines 1720 1720 Branches 206 212 +6 ======================================= Hits 1526 1526 + Misses 194 179 -15 - Partials 0 15 +15 ```

:umbrella: View full report in Codecov by Sentry.
:loudspeaker: Have feedback on the report? Share it here.

slifty commented 4 months ago

@bickelj rather than manually update these could you disable major versions on eslint via an edit to dependabot.yml so that we can benefit from dependabot going forward (these dependencies update pretty regularly), and then open a tracking issue to re-enable major eslint updates once the deps support it?

slifty commented 4 months ago

Actually scratch that I opened a PR / issue to that effect: https://github.com/PhilanthropyDataCommons/service/pull/979 #978

bickelj commented 4 months ago

@slifty Can we have dependabot notify us once the ESLint dependencies work together with ESLint 9?

bickelj commented 4 months ago

I still prefer this to #979 but someone had to give somewhere, and this time it was me.