PhilanthropyDataCommons / service

A project for collecting and serving public information associated with grant applications
GNU Affero General Public License v3.0
8 stars 2 forks source link

Ignore eslint major dependency updates #979

Closed slifty closed 4 months ago

slifty commented 4 months ago

This PR disables dependabot for eslint 9 for now (we'll re-enable once our other dependencies support it)

Related to #978

codecov[bot] commented 4 months ago

Codecov Report

All modified and coverable lines are covered by tests :white_check_mark:

Project coverage is 88.72%. Comparing base (ba263cd) to head (80b7818). Report is 4 commits behind head on main.

Additional details and impacted files ```diff @@ Coverage Diff @@ ## main #979 +/- ## ======================================= Coverage 88.72% 88.72% ======================================= Files 127 127 Lines 1720 1720 Branches 206 212 +6 ======================================= Hits 1526 1526 Misses 194 194 ```

:umbrella: View full report in Codecov by Sentry.
:loudspeaker: Have feedback on the report? Share it here.

bickelj commented 4 months ago

@slifty The thing is, we do want eslint 9, right? And instead of manually polling for whether it works with upstream dependencies, we can let dependabot attempt the upgrade every so often. That was my reasoning earlier.

slifty commented 4 months ago

@bickelj it will be a constant source of pain (those dependencies update a few times a week on average) over the span of months. Unfortunately I think that our best options are either:

  1. Human-level ignore the broken dependabot PRs (which we've generally been doing the past two weeks or so, but it is DEFINITELY very noisy)
  2. Settings-level ignore the specific dependency that doesn't work until the peer dependency upgrades.

Without (2) then we're doing (2) to some extent either way.

I think 2 is an appropriate way to go here -- it lets us stay up to date through automation with no noise. It's very likely that when our typescript-eslint updates it will require the new eslint as a peer dependency (I don't know why they would go out of their way to support an old version of eslint when the two versions are so fundamentally incompatible), so we'll naturally be informed that it's time to fix that up.