Closed slifty closed 4 months ago
All modified and coverable lines are covered by tests :white_check_mark:
Project coverage is 88.72%. Comparing base (
ba263cd
) to head (80b7818
). Report is 4 commits behind head on main.
:umbrella: View full report in Codecov by Sentry.
:loudspeaker: Have feedback on the report? Share it here.
@slifty The thing is, we do want eslint 9, right? And instead of manually polling for whether it works with upstream dependencies, we can let dependabot attempt the upgrade every so often. That was my reasoning earlier.
@bickelj it will be a constant source of pain (those dependencies update a few times a week on average) over the span of months. Unfortunately I think that our best options are either:
Without (2) then we're doing (2) to some extent either way.
I think 2 is an appropriate way to go here -- it lets us stay up to date through automation with no noise. It's very likely that when our typescript-eslint updates it will require the new eslint as a peer dependency (I don't know why they would go out of their way to support an old version of eslint when the two versions are so fundamentally incompatible), so we'll naturally be informed that it's time to fix that up.
This PR disables dependabot for eslint 9 for now (we'll re-enable once our other dependencies support it)
Related to #978