search

PhilanthropyDataCommons / service

A project for collecting and serving public information associated with grant applications
GNU Affero General Public License v3.0
8 stars 2 forks source link

Use json for proposal field values #983

Closed slifty closed 4 months ago

slifty commented 4 months ago

This PR updates our proposal field value query to use JSON and utilize a database utility for access.

It also simplifies one of our more complicated tests in a way that lets us also remove a proposal field value query that was ONLY being used for that one test 🎉.

Related to #821 Related to #228

codecov[bot] commented 4 months ago

Codecov Report

Attention: Patch coverage is 95.23810% with 1 lines in your changes are missing coverage. Please review.

Project coverage is 88.50%. Comparing base (2d19b83) to head (366a176). Report is 1 commits behind head on main.

Files Patch % Lines
...base/operations/create/createProposalFieldValue.ts 90.90% 1 Missing :warning:
Additional details and impacted files ```diff @@ Coverage Diff @@ ## main #983 +/- ## ========================================== - Coverage 88.75% 88.50% -0.25% ========================================== Files 127 128 +1 Lines 1725 1723 -2 Branches 218 219 +1 ========================================== - Hits 1531 1525 -6 - Misses 179 183 +4 Partials 15 15 ```

:umbrella: View full report in Codecov by Sentry.
:loudspeaker: Have feedback on the report? Share it here.