search

PhilanthropyDataCommons / service

A project for collecting and serving public information associated with grant applications
GNU Affero General Public License v3.0
8 stars 2 forks source link

Use json for proposal versions #984

Closed slifty closed 4 months ago

slifty commented 4 months ago

This PR updates our proposal version queries to use db utilities as well as the json return pattern.

Related to #821 Related to #228

codecov[bot] commented 4 months ago

Codecov Report

Attention: Patch coverage is 96.29630% with 1 lines in your changes are missing coverage. Please review.

Project coverage is 88.57%. Comparing base (1a54a86) to head (6b37dfc). Report is 10 commits behind head on main.

Files Patch % Lines
...atabase/operations/create/createProposalVersion.ts 90.90% 1 Missing :warning:
Additional details and impacted files ```diff @@ Coverage Diff @@ ## main #984 +/- ## ========================================== + Coverage 88.50% 88.57% +0.06% ========================================== Files 128 129 +1 Lines 1723 1724 +1 Branches 219 220 +1 ========================================== + Hits 1525 1527 +2 + Misses 183 182 -1 Partials 15 15 ```

:umbrella: View full report in Codecov by Sentry.
:loudspeaker: Have feedback on the report? Share it here.