PhilanthropyDataCommons / service

A project for collecting and serving public information associated with grant applications
GNU Affero General Public License v3.0
8 stars 2 forks source link

Rename `employer_identification_number` to `tax_id` #985

Closed slifty closed 4 months ago

slifty commented 4 months ago

This PR updates the Organization entity to have a taxId rather than the US-centric EmployerIdentificationNumber. The old value is still there, but is marked as deprecated and will be removed once we've updated our front-end to use the new attribute.

Related to #931

codecov[bot] commented 4 months ago

Codecov Report

All modified and coverable lines are covered by tests :white_check_mark:

Project coverage is 88.73%. Comparing base (ee40841) to head (6ed97a5). Report is 6 commits behind head on main.

Additional details and impacted files ```diff @@ Coverage Diff @@ ## main #985 +/- ## ======================================= Coverage 88.73% 88.73% ======================================= Files 127 127 Lines 1722 1722 Branches 215 215 ======================================= Hits 1528 1528 - Misses 179 194 +15 + Partials 15 0 -15 ```

:umbrella: View full report in Codecov by Sentry.
:loudspeaker: Have feedback on the report? Share it here.