Closed slifty closed 1 month ago
@slifty Ah, I'm glad you asked! Yes, I would expect the value to be lowercase. At least, alongside the other enum values:
export enum BaseFieldDataType { STRING = 'string', NUMBER = 'number', PHONE_NUMBER = 'phone_number', EMAIL = 'email', URL = 'URL', BOOLEAN = 'boolean', }
Originally posted by @reefdog in https://github.com/PhilanthropyDataCommons/service/issues/975#issuecomment-2091930999
Our enum values are all snake_case except for URL which has capitalization. We should be consistent. Yes this does mean creating a migration unfortunately, but that's OK!
URL
Originally posted by @reefdog in https://github.com/PhilanthropyDataCommons/service/issues/975#issuecomment-2091930999
Our enum values are all snake_case except for
URL
which has capitalization. We should be consistent. Yes this does mean creating a migration unfortunately, but that's OK!