search

Phildo / pixQL

SQL for image processing
386 stars 7 forks source link

reserved identifier violation #5

Closed elfring closed 9 years ago

elfring commented 9 years ago

I would like to point out that identifiers like "_BITMAP_H_" and "_PIX_H_" do not fit to the expected naming convention of the C language standard. Would you like to adjust your selection for unique names?

Phildo commented 9 years ago

Thanks! I had no idea. Will do when I get home (at work, atm, hah). :)

elfring commented 9 years ago

Would it be better to keep this bug report open until it will be really fixed?

Phildo commented 9 years ago

haha good call :P (pretty new to the whole "github OSS" thing hah)

elfring commented 9 years ago

Thanks for your improvement of affected include guards.

Will any of the updated source files become a component for an application programming interface?

Phildo commented 9 years ago

Will any of the updated source files become a component for an application programming interface?

I'm not sure I understand the question- are you wondering whether I intend on packaging pixQL as a library? I'm not sure. The project is too young to tell. But if I did, I think some serious code and even design refactoring would take place before doing so, so I don't want to get hung up on setting up the codebase as it currently stands for that kind of application just yet.

elfring commented 9 years ago

How do you think about the design of safe APIs and corresponding libraries for your application domain?

Phildo commented 9 years ago

I don't mean to offend, but I'm starting to think that maybe you're a bot connected to some kind of static analysis tool, hah.

I'm not too worried about designing particularly safe APIs at this moment in time. As it currently exists, it is an experimental user-facing command line image editing tool, and that's it. It isn't intended to be connected to by any networks or given much opportunity for potentially malicious input.

For clarity's sake- I'm not saying "I don't care if pixQL isn't secure or well architected". I'm saying "I'm not yet worried about security or API extensibility at this point in the project's life".