PhileCMS / Phile

A flat file CMS with a swappable parser and template engine.
https://philecms.github.io/
Other
257 stars 49 forks source link

allows content modification on before_parse_content event #105

Closed Schlaefer closed 10 years ago

james2doyle commented 10 years ago

This is already possible since the current page is being passed by reference. You can use the setContent method.

https://github.com/PhileCMS/Phile/blob/master/lib/Phile/Model/Page.php#L100

You are also using the older version of Phile. Check out 1.1.1

Schlaefer commented 10 years ago

This is already possible since the current page is being passed by reference. You can use the setContent method.

Ah, ok. Thanks. Nonetheless the getter, setter, naming, "what's passed around as reference" on events is a little bit inconsistent/unexpected.

You are also using the older version of Phile. Check out 1.1.1

I'm aware of 1.x, but because there's no official release I stayed away from it. Is it considered production ready?

james2doyle commented 10 years ago

Yeah our docs need some love. The event arguments for that particular event are a little strange, we should probably change them.

Yeah it's production ready. I have been using it for months on live client projects. We just need to find the time to toggle the switch on the master repo and update the site etc.

Schlaefer commented 10 years ago

Ok, I'll update to 1.x. Thanks. :)