[TASK] Forgo v1.2.1 and go to v.2.0

[james2doyle]

Since we just dropped PHP 5.3 that would be considered a breaking change, therefore we should have a version bump.

According to semver:

Given a version number MAJOR.MINOR.PATCH, increment the:

MAJOR version when you make incompatible API changes, MINOR version when you add functionality in a backwards-compatible manner, and PATCH version when you make backwards-compatible bug fixes.

[NeoBlack]

I do not think we should go to version 2.0. we had much earlier to drop the support for 5.3, maybe before 1.0.0 of phile.

[james2doyle]

Here is the changelog as of this moment.

• [x] 5e18555 by [James Doyle](https://github.com/James Doyle) - Merge pull request #123 from NeoBlack/feature/changeMinPHPVersion
• [x] 5f165bd by [Frank Nägler](https://github.com/Frank Nägler) - change PHP minimum version to PHP 4.5.0
• [x] 8d15752 by [James Doyle](https://github.com/James Doyle) - Merge pull request #119 from NeoBlack/bugfix/PageRepository
• [x] d08a07c by [James Doyle](https://github.com/James Doyle) - Merge pull request #117 from NeoBlack/bugfix/htaccess
• [x] 98fdca4 by [Frank Nägler](https://github.com/Frank Nägler) - change badge to show only status of master builds
• [x] 41139af by [Frank Nägler](https://github.com/Frank Nägler) - [BUGFIX] page repository works with wrong pathes
• [x] 7c20ab5 by [Frank Nägler](https://github.com/Frank Nägler) - [BUGFIX] fix trailing slash rewrite in htaccess
• [x] 8360c99 by [Frank Nägler](https://github.com/Frank Nägler) - Revert "[BUGFIX] fix trailing slash rewrite in htaccess"
• [x] 17c2e6a by [Frank Nägler](https://github.com/Frank Nägler) - [BUGFIX] fix trailing slash rewrite in htaccess
• [x] c1f1356 by [James Doyle](https://github.com/James Doyle) - Merge pull request #115 from Stijn-Flipper/patch-1
• [x] ab82bd6 by Stijn-Flipper - [BUGFIX] Make sorting actually works
• [x] 285fe8f by [Frank Nägler](https://github.com/Frank Nägler) - change gitter.im notification url
• [x] 313a88f by [Frank Nägler](https://github.com/Frank Nägler) - Merge branch 'release/1.0.0'
• [x] 155aaa4 by [James Doyle](https://github.com/James Doyle) - Merge pull request #110 from NeoBlack/release/1.0.0
• [x] 93ee635 by [Frank Nägler](https://github.com/Frank Nägler) - update travis file with gitter.im support
• [x] 9224769 by [Frank Nägler](https://github.com/Frank Nägler) - remove composer.lock from git ignore file
• [x] 47c94b8 by [Frank Nägler](https://github.com/Frank Nägler) - update Changelog file
• [x] b7a69ad by [James Doyle](https://github.com/James Doyle) - Merge pull request #112 from Stijn-Flipper/patch-live-edit
• [x] 992d638 by Stijn-Flipper - ignore md files with a leading dot '.' as filename
• [x] 70ca14f by [Frank Nägler](https://github.com/Frank Nägler) - updated changlog and readme
• [x] b51a84e by [Frank Nägler](https://github.com/Frank Nägler) - added travis ci badge
• [x] 243e2a8 by [Frank Nägler](https://github.com/Frank Nägler) - update php lint command
• [x] e8d0083 by [Frank Nägler](https://github.com/Frank Nägler) - fix cli mode check
• [x] e3e4ce0 by [Frank Nägler](https://github.com/Frank Nägler) - disable phpFastCache in CLI mode, it will not work
• [x] 4993080 by [Frank Nägler](https://github.com/Frank Nägler) - added check of CLI mode
• [x] 0be00eb by [Frank Nägler](https://github.com/Frank Nägler) - added travis file and some basic unit tests
• [x] e669bce by [Frank Nägler](https://github.com/Frank Nägler) - [FEATURE] refactor bootstrapping

I dont think going to 1.2.1 makes sense. Maybe going to 1.3.0 now?

[NeoBlack]

1.3.0 is ok for me, but we should merge the two last pull request before next release, then we have also a good base for unit testings. I will move all issues and pull request to milestone 1.3.0

[james2doyle]

Yeah that is what I am suggesting. For the next version bump we should definitely do 1.3.0

[james2doyle]

I will generate the new changelog and bump the versions

[NeoBlack]

result from the last merge for next release: Tests: 33, Assertions: 42, Incomplete: 1. looks good :) I think we should make a feature freeze and release 1.3.0 next week after some manual testings.

[james2doyle]

Sure. I have a branch ready on my Github with the bump so if everything is good it will be fine.

https://github.com/james2doyle/Phile/commit/3e4facece9ed8a0c6e9f5b777ee0aac2137219a8

[NeoBlack]

yeah, cool. I love GIT :) But in your changelog are a lot of URL which looks like this: https://github.com/AUTHOR/REPO/commit/68281e5ffd15447d76a23e88e9ae6d82c1160aa0

because the /AUTHOR/REPO/ the links not working.

[james2doyle]

Oh whoops I need to fix that

On Friday, August 22, 2014, Frank Nägler notifications@github.com wrote:

yeah, cool. I love GIT :) But in your changelog are a lot of URL which looks like this: AUTHOR/REPO@68281e5 https://github.com/AUTHOR/REPO/commit/68281e5ffd15447d76a23e88e9ae6d82c1160aa0

because the /AUTHOR/REPO/ the links not working.

— Reply to this email directly or view it on GitHub https://github.com/PhileCMS/Phile/issues/124#issuecomment-53119276.

James Doyle

t: @james2doyle https://twitter.com/james2doylew: ohdoylerules.com http://ohdoylerules.com

[NeoBlack]

I change the travis file to use PHPUnit 4.2.2, now all tests passed also under hhvm.

[james2doyle]

I would be curious to see the hhvm performance vs normal PHP. Also seeing PHPng performance would be cool too

[NeoBlack]

Ok, i think we are now ready for 1.3.0. can you Update your branch and create a new changelog file and pull request?

[NeoBlack]

release 1.3.0 is out now, I will close this issue