PhileCMS / Phile

A flat file CMS with a swappable parser and template engine.
https://philecms.github.io/
Other
257 stars 49 forks source link

[TASK] Clean-Ups for a better core update #133

Closed NeoBlack closed 8 years ago

NeoBlack commented 10 years ago
  1. move cache, datastorage and vendor folder outside the libfolder this is important for the point 4.
  2. move core plugins into a seperate folder this is important for the point 4.
  3. move the folder themes and content outside the core this is important for the point 4.
  4. makes it possible to change the core by switching a symlink

A structure like TYPO3 with separating the core from content, themes, etc.

STOWouters commented 10 years ago
  1. I completely agree with point 1. :+1:
  2. Why would you move the core plugins into a separate folder? Are there significant differences between core plugins and 3rd party plugins?
  3. Maybe I don't understand you, but themes and content doesn't have anything to do with the core code, what do you mean with 'moving outside the core'?
  4. Why would you switch between different cores? Can you give an use case to clarify what you mean?

Because you're reorganizing the structure, I wouldn't even dare to say this is a minor change, I would rather label it to v1.4 instead.

NeoBlack commented 10 years ago
  1. yes, core plugins are delivered with core, third party plugins not. If we want replace the core with a symlink or with renaming of the "core" folder, we have to copy the plugins around.
  2. yes, but currently, content and themes are part of the core logic
  3. e.g. I want to update to the latest version, but not sure if everythink works, I need to make a complete backup before update. but if I can switch the core by a symlink, I can copy the new core to my server, switch the symlink to the new core and if any problems occur, I can switch back.

here are an example folder structure:

now it is possible to switch between release 1.2.0 and 1.3.0 by change the phile_core symlink.

STOWouters commented 10 years ago

Ok, now I understand :D Yes, I agree with that, looks a very good, solid organisation.

I wouldn't consider that as a small patch (v1.3.1), I would rather call it a v1.4. instead. It's even worth a v2.0.

NeoBlack commented 10 years ago

yeah, you are right. I create a milestone for 1.4.0 and add this task to it.

Schlaefer commented 10 years ago

Thumbs up :+1:

Last week I thought: let's reshuffle everything to make Phile updatable via composer update, but then … naah, to much work. ;)

NeoBlack commented 10 years ago

I created some sub task, which are also clean-ups for a better code and quality.

Subtasks: #157, #156, #155, #154, #153, #151, #148