[BUGFIX] Nginx: https/http protocol detection

[DenBeke]

In Nginx the $_SERVER['HTTPS'] is always set, but when it is not https, it will be empty.

In Wordpress they use the following function

function is_ssl() {
    if ( isset($_SERVER['HTTPS']) ) {
        if ( 'on' == strtolower($_SERVER['HTTPS']) )
            return true;
        if ( '1' == $_SERVER['HTTPS'] )
            return true;
    } elseif ( isset($_SERVER['SERVER_PORT']) && ( '443' == $_SERVER['SERVER_PORT'] ) ) {
        return true;
    }
    return false;
}

Checking for the port is not very good, imho, but the first part of the function should be correct. Instead of checking for the variable not to be off, you should check for it to be on.

I have tested it on Nginx with/without https. I have tested it on Apache without https, but haven't any https Apache hosts where I can check it.

So please do some little testing before merging it. I have fixed this for a client, running on my Nginx installation, but I'm not experienced with PhileCMS, so please test a bit more than I have doen :)

[STOWouters]

I can add confirmly that it works for me :+1:

(and yes, I'm that client :smile: )

[NeoBlack]

Please change the line to:

if (!empty($_SERVER['HTTPS']) && strtolower($_SERVER['HTTPS']) !== 'off' ) {

If this work, please update your pull request and I am fine with a merge.

thanks.

[NeoBlack]

sorry, accidentally clicked the close button

[DenBeke]

Your solution is indeed correct as well, and stays closer to the original implementation.

[DenBeke]

(Oh, and sorry, I should have used [BUGFIX] instead of [FIX]. How can I change this?)