search

PhileCMS / Phile

A flat file CMS with a swappable parser and template engine.
https://philecms.github.io/
Other
257 stars 49 forks source link

Fix warning in backtrace generation (don't assume there's a class) #203

Closed marado closed 9 years ago

Schlaefer commented 9 years ago

Hi @marado , thanks for the pull-request!

There's already an open pull-request addressing the same issue plus a little bit more in #191. It is stalled because nobody else reviewed and approved it yet.

Phile tries an "at least two pair of eyes must approve" policy to pull requests. Your PR is probably more than enough to establish that there is a problem. :+1:

Also Phile tries to perform all development on the "develop" branch. If you could do another pull request with your changes against the "develop" branch instead of "master" (just close this one) I'm happy to merge it and base additional changes made in #191 on top of it.

marado commented 9 years ago

The patch addressing this issue in #191 looks fine to me, so I'll just close this one.