search

PhileCMS / Phile

A flat file CMS with a swappable parser and template engine.
https://philecms.github.io/
Other
257 stars 49 forks source link

rename phile icon in error handler plugin, fix #211 #216

Closed Schlaefer closed 9 years ago

Schlaefer commented 9 years ago

this is a weasel solution but it should do the job

STOWouters commented 9 years ago

:-1:

You don't have to rename the file, instead just remove this line from .gitattributes.

I've added it to .gitattributes on PR #200 because I thought it was some leftover development file.

Schlaefer commented 9 years ago

You don't have to rename the file, instead just remove this line

If we remove the line the icon file in the root is in again, and we don't need that.

PS: I guess the right solution is to prefix everything in gitattributes with a slash, but I was to lazy to test that.

STOWouters commented 9 years ago

Oh now I see. Yeah, prefixing it with a slash will do the job.

but I was to lazy to test that.

Heh :p

Schlaefer commented 9 years ago

Let's merge this (no harm done) and #220 and after that a new PR adding a slash prefix to all the root files in .gitattributes (if that works, still have to test it :wink:).

STOWouters commented 9 years ago

Let's merge this (no harm done) and #220 and after that a new PR adding a slash prefix to all the root files in .gitattributes (if that works, still have to test it ).

:+1: