improve ErrorHandler\Development

PhileCMS / Phile

A flat file CMS with a swappable parser and template engine.

https://philecms.github.io/

Other

257 stars 49 forks source link

improve ErrorHandler\Development #231

Closed Schlaefer closed 9 years ago

Schlaefer commented 9 years ago

remove deprecated calls
fix an issue if exception/error is thrown near start or end of file
fix code lines are not entity-encoded
render code snippet for exception and error
improve catching errors
show method arguments in backtrace as tooltip

infostreams commented 9 years ago

I don't want to discourage this work, and I think what we have here already is great, but how about using an existing awesome solution like Whoops (see demo here)? We could benefit from their work and subsequent updates for free, and we could simplify our own code base at the same time. Worth considering?

Schlaefer commented 9 years ago

Actually I considered whoops, but wasn't 100% convinced. Mainly fixable layout/presentation issues.

With these changes I'm happy with Phile's current state. But if nobody maintains the error handler (in the future) or whoops is better™ I personally have no strong opinion not to switch.

infostreams commented 9 years ago

Ok, thanks for answering, I was mainly just curious but see no strong reason to switch either.