PhileCMS / Phile

A flat file CMS with a swappable parser and template engine.
https://philecms.github.io/
Other
257 stars 49 forks source link

[TASK] Updates phpFastCache from version 3 to 6 #306

Closed Schlaefer closed 6 years ago

Schlaefer commented 6 years ago

This updates phpFastCache from version 3 to 6 (last version working with PHP 5.6).

Alas the phpFastCache-API is not completely compatible anymore: the $option argument in CacheInterface::set($key, $value, $time, $options) and CacheInterface::delete($key, $options) isn't available and easily implemented.

So this commit marks $option as deprecated, ignores it and throws a warning if used. I think this change is OK, I never saw someone using it.

On the other hand the Phile cache API nearly matches the PSR-16 specs now. So talking to phpFastCache can utilize their PSR-16 API and is essentially a lightweight adapter to PSR-16.

With that Phile may easily drop its own cache interface and implementation to just embrace the PSR-16 interface in the future.

@PhileCMS/Phile please review this pull request