PhileCMS / Phile

A flat file CMS with a swappable parser and template engine.
https://philecms.github.io/
Other
257 stars 49 forks source link

Improve testing to detect plugin breakage. #324

Closed Schlaefer closed 6 years ago

Schlaefer commented 6 years ago

This PR should give us a basic idea if a core change accidentally breaks plugins or if plugins need updating after a deliberately breaking core change. Having plugins which can be easily pulled-in via composer is great, having them not work makes them rather useless.

So this PR adds a new phing tasks which installs additional plugins (currently phile/rss-feed only). On travis-ci this task is executed and installs the plugins before tests are run. So if plugins have test-cases – I added a basic test case to phile/rss-feed – those plugin tests are executed too.

Additional plugins can be updated with test cases and added over time.

Pro: plugins should be become more reliable. Con: it's a commitment to actually keep plugins up to date and those popular "it's slightly breaking but probably not a problem" core changes become harder.

Something should be done to detect plugin breakage. I'm not saying that this is the best solution/implementation, lets just have something raising a flag somewhere. Better ideas welcome.