search

Philio / PinEntryView

A pin entry view widget for Android.
222 stars 83 forks source link

Fix a bug with digitTextSize #20

Closed Fideas closed 8 years ago

Fideas commented 8 years ago

On the PinEntryView builder digitTextSize gets its value from he method array.getDimensionPixelSize, which returns an int that represents the dimension in PIXELS. After that on the addViews method this value is fed to the TextView.setTextSize(float) method that expects a value in DENSITY INDEPENDENT PIXELS. This causes the digits to look different on each screen based on that screen's resolution (higher resolution will show bigger numbers). I fixed this issue by using TextView.setTextSize(int, float) instead and setting the unit of the dimension to be PX instead of DP

ricknout commented 7 years ago

Any chance we will see a release (soon) with this fix?