search

Philio / bootstrapdefault

A modern and responsive theme for Piwigo built with standard Bootstrap components and using the default Bootstrap theme. Intended for easy customisation using Bootstrap styles or as a parent theme for creating responsive themes for Piwigo.
https://philio.me
31 stars 10 forks source link

Rating display issues in picture.tpl #26

Open tkuther opened 8 years ago

tkuther commented 8 years ago

Hi,

I'm using latest Piwigo 2.8.0 and absolutely love your bootstrap theme. I noticed some issues with the display of ratings below the image on picture.tpl, though.

a) the setting from Administration -> Configuration -> Options -> Display -> "Rating" is ignored. Rating is displayed even when it's disabled there. b) Guests can see the text "Rate this image" (no stars though), even "guests can rate" is disabled in Configuration -> Options -> Common -> Permissions. They shouldn't see the text at all. c) Guests can not see the stars after "Average rating" even the picture has been rated (if there is no rating, this is to be expected) when "guests can rate" is disabled. They should be able to see both the text and the stars (unless it's disabled, see a))

I'm trying to come up with a pull request. a) should be easy, the other two require some deeper dive into Piwigo's template variable stuff.

tkuther commented 8 years ago

.. I was unable to fix c), that needs patching include/picture_rate.inc.php in Piwigo itself.

Philio commented 8 years ago

Sorry for the long time to respond and thanks for the PR, I'll look at getting this merged.

Philio commented 8 years ago

I've merged the PR, will see if I can find a workaround for c at some point in the future.