search

Philio / bootstrapdefault

A modern and responsive theme for Piwigo built with standard Bootstrap components and using the default Bootstrap theme. Intended for easy customisation using Bootstrap styles or as a parent theme for creating responsive themes for Piwigo.
https://philio.me
31 stars 10 forks source link

Theme Switcher not working #39

Open gsnde opened 7 years ago

gsnde commented 7 years ago

Hi.

The theme switcher brush icon is visible, but not operational. I checked with the other themes I have installed (elegant, flop_mauve & stripped_responsive). There the brush icon triggers the theme switch.

Thanks for having a look!

best regards Martin

Philio commented 7 years ago

I'll have to look into this and get back to you.

plegall commented 7 years ago

I suppose it's the same issue as Batch Downloader, Language Switch or User Collections. On Batch Downloader https://github.com/mistic100/Piwigo-BatchDownloader/commit/c99528702856d9f469665ab81bdc6b0478476c8c and User Collections https://github.com/mistic100/Piwigo-User-Collections/commit/e428004f3d228d60ac05f2d7b78694d08ce46998 I had to push a little change to give themes the ability to use their own template for the dropdown box. Maybe we have to do it as well for Language Switch and Theme Switch to fix this problem in a clean way.

gsnde commented 7 years ago

Thanks for your feedback!

Will you announce it here when a fix has been made?

gsnde commented 7 years ago

Good morning.

I checked today and the Bootstrap theme 1.0.5 still has the issue with the theme switcher (icon to switch to other theme does nothing) as far as I can see. Can you please confirm that the issue is still unsolved or is something wrong with my setup?

Best regards

Martin

From: Pierrick Le Gall [mailto:notifications@github.com] Sent: Donnerstag, 16. Februar 2017 10:18 To: Philio/bootstrapdefault bootstrapdefault@noreply.github.com Cc: gsnde martin.gossmann@interkultur.de; Author author@noreply.github.com Subject: Re: [Philio/bootstrapdefault] Theme Switcher not working (#39)

I suppose it's the same issue as Batch Downloader, Language Switch or User Collections. On Batch Downloader mistic100/Piwigo-BatchDownloader@ https://github.com/mistic100/Piwigo-BatchDownloader/commit/c99528702856d9f469665ab81bdc6b0478476c8c c995287 and User Collections mistic100/Piwigo-User-Collections@ https://github.com/mistic100/Piwigo-User-Collections/commit/e428004f3d228d60ac05f2d7b78694d08ce46998 e428004 I had to push a little change to give themes the ability to use their own template for the dropdown box. Maybe we have to do it as well for Language Switch and Theme Switch to fix this problem in a clean way.

— You are receiving this because you authored the thread. Reply to this email directly, view it on GitHub https://github.com/Philio/bootstrapdefault/issues/39#issuecomment-280276446 , or mute the thread https://github.com/notifications/unsubscribe-auth/AIOXfn59g86_28OmeXnmtLtpf-Al6Bl-ks5rdBQygaJpZM4K4QCq . https://github.com/notifications/beacon/AIOXfjBXe9FdJ1cCbqXqTKfyBCr1GayZks5rdBQygaJpZM4K4QCq.gif

gsnde commented 7 years ago

Hi Phil,

I have just updated to Piwigo 2.9.0.

My favorite theme Bootstrap Default still does not work with the theme switcher. Any chance you can fix that?

One thing I noticed… I am always offered version 1.0.6. But after it has been installed, the version is still 1.0.5.

I made a download instead of an install, but the files on the server and in the Zip are identical.

Might it be that you have fixed the issue with version 1.0.6 but a wrong file has been provided to the Piwigo update mechanism?

Thanks for a short feedback and best regards

Martin

From: Phil Bayfield [mailto:notifications@github.com] Sent: Donnerstag, 16. Februar 2017 01:25 To: Philio/bootstrapdefault bootstrapdefault@noreply.github.com Cc: gsnde martin.gossmann@interkultur.de; Author author@noreply.github.com Subject: Re: [Philio/bootstrapdefault] Theme Switcher not working (#39)

I'll have to look into this and get back to you.

— You are receiving this because you authored the thread. Reply to this email directly, view it on GitHub https://github.com/Philio/bootstrapdefault/issues/39#issuecomment-280188112 , or mute the thread https://github.com/notifications/unsubscribe-auth/AIOXfg6i28l6hifwW2RBAGQexxUS4L3wks5rc5dhgaJpZM4K4QCq . https://github.com/notifications/beacon/AIOXfrpPX8DMHwqVsD77ZMEwCeN3wSZXks5rc5dhgaJpZM4K4QCq.gif

gsnde commented 7 years ago

Hi Phil,

I noticed that you have updated the Bootstrap Default theme – my pleasure to have that bug reported.

Still I would very much appreciate some feedback why the theme switch extension is not working with Bootstrap Default. It is the only theme I use that has this issue.

Normally by clicking on the ‘Interface theme’ brush you can display all activated themes and select one.

The issue in case that has been forgotten is that the ‘Interface theme’ brush has no link property with Bootstrap Default. Here it is not more than a useless icon.

So my questions are:

Thanks again for any feedback!

Best regards

Martin

From: Martin Gossmann [mailto:martin.gossmann@interkultur.de] Sent: Freitag, 5. Mai 2017 23:30 To: 'Philio/bootstrapdefault' reply@reply.github.com; 'Philio/bootstrapdefault' bootstrapdefault@noreply.github.com Cc: 'Author' author@noreply.github.com Subject: RE: [Philio/bootstrapdefault] Theme Switcher not working (#39)

Hi Phil,

I have just updated to Piwigo 2.9.0.

My favorite theme Bootstrap Default still does not work with the theme switcher. Any chance you can fix that?

One thing I noticed… I am always offered version 1.0.6. But after it has been installed, the version is still 1.0.5.

I made a download instead of an install, but the files on the server and in the Zip are identical.

Might it be that you have fixed the issue with version 1.0.6 but a wrong file has been provided to the Piwigo update mechanism?

Thanks for a short feedback and best regards

Martin

From: Phil Bayfield [mailto:notifications@github.com] Sent: Donnerstag, 16. Februar 2017 01:25 To: Philio/bootstrapdefault <bootstrapdefault@noreply.github.com mailto:bootstrapdefault@noreply.github.com > Cc: gsnde <martin.gossmann@interkultur.de mailto:martin.gossmann@interkultur.de >; Author <author@noreply.github.com mailto:author@noreply.github.com > Subject: Re: [Philio/bootstrapdefault] Theme Switcher not working (#39)

I'll have to look into this and get back to you.

— You are receiving this because you authored the thread. Reply to this email directly, view it on GitHub https://github.com/Philio/bootstrapdefault/issues/39#issuecomment-280188112 , or mute the thread https://github.com/notifications/unsubscribe-auth/AIOXfg6i28l6hifwW2RBAGQexxUS4L3wks5rc5dhgaJpZM4K4QCq . https://github.com/notifications/beacon/AIOXfrpPX8DMHwqVsD77ZMEwCeN3wSZXks5rc5dhgaJpZM4K4QCq.gif

gsnde commented 7 years ago

Hi Pierre,

I have meanwhile updated to Piwigo 2.9.0. I have also updated to the latest version of the Bootstrap Default theme.

My issue is still the same. On all other themes I have installed your theme switcher works, but not so with Bootstrap Default.

My problem is that I fail to understand if this is caused by the theme or by the extension.

Would you please be so kind to give me a feedback?

Thanks a lot for coming back to me – most appreciated.

Best regards

Martin

From: Pierrick Le Gall [mailto:notifications@github.com] Sent: Donnerstag, 16. Februar 2017 10:18 To: Philio/bootstrapdefault bootstrapdefault@noreply.github.com Cc: gsnde martin.gossmann@interkultur.de; Author author@noreply.github.com Subject: Re: [Philio/bootstrapdefault] Theme Switcher not working (#39)

I suppose it's the same issue as Batch Downloader, Language Switch or User Collections. On Batch Downloader mistic100/Piwigo-BatchDownloader@ https://github.com/mistic100/Piwigo-BatchDownloader/commit/c99528702856d9f469665ab81bdc6b0478476c8c c995287 and User Collections mistic100/Piwigo-User-Collections@ https://github.com/mistic100/Piwigo-User-Collections/commit/e428004f3d228d60ac05f2d7b78694d08ce46998 e428004 I had to push a little change to give themes the ability to use their own template for the dropdown box. Maybe we have to do it as well for Language Switch and Theme Switch to fix this problem in a clean way.

— You are receiving this because you authored the thread. Reply to this email directly, view it on GitHub https://github.com/Philio/bootstrapdefault/issues/39#issuecomment-280276446 , or mute the thread https://github.com/notifications/unsubscribe-auth/AIOXfn59g86_28OmeXnmtLtpf-Al6Bl-ks5rdBQygaJpZM4K4QCq . https://github.com/notifications/beacon/AIOXfjBXe9FdJ1cCbqXqTKfyBCr1GayZks5rdBQygaJpZM4K4QCq.gif

Philio commented 7 years ago

There are some outstanding PRs which fix a couple of the theme compatibility issues, but I don't think that applies to the theme switcher.

I'll try and look at these later this week and see if it's possible to also fix the theme switcher.