Philio / bootstrapdefault

A modern and responsive theme for Piwigo built with standard Bootstrap components and using the default Bootstrap theme. Intended for easy customisation using Bootstrap styles or as a parent theme for creating responsive themes for Piwigo.
https://philio.me
31 stars 10 forks source link

Removed $themeconf.name to allow for child themes #4

Closed inxilpro closed 9 years ago

inxilpro commented 9 years ago

Using $themeconf.name in the {combine_script} and {combine_css} calls means that if you create a child theme of bootstrapdefault, the template system looks in the wrong place for those files. For example, if I create a child theme called mytheme, it will look for themes/mytheme/bootstrap/dist/css/bootstrap.min.css instead of themes/bootstrapdefault/bootstrap/dist/css/bootstrap.min.css.

This means that you either have to create your own custom copies of these templates, or duplicate the JavaScript and CSS resources in your child theme.

Switching from $themeconf.name to bootstrapdefault solves this problem.

Philio commented 9 years ago

Thanks for the info, I'm not overly familiar with the inner workings of Piwigo. I'll test this later today when I've finished work.