search

Philip-Scott / Notes-up

Markdown notes editor & manager
GNU General Public License v2.0
621 stars 47 forks source link

Switch to meson #316

Closed NathanBnm closed 2 years ago

NathanBnm commented 5 years ago

Hi! Everything seems to build fine but someone more familiar with meson and elementary development should take a look at this. Hope you'll appreciate it :smile:

Changelog

This PR is ready for review

NathanBnm commented 5 years ago

Hello, and first of all thank you for your contribution! :)

So before merging anything, i'd like to ask of you a couple of things to make reviewing this easier as it's a 430 file PR with over 150k lines...

Can you split the PR into two, this one for adding the meson system, and another one to remove it

I'm not sure about how to do that, can you help? You mean one for adding meson, and the other to remove CMake?

Don't generate (or at least don't add to the PR) the .po files, and changes to the .pot file, i'll take care of that :)

Can you please say why? I took time to do that. I also added existing translations back. In fact, a lot of apps, including elementary OS apps are doing this (generating all translations language files). This is easier to translate and prevents people to create invalid translation files.

This will make the PR smaller and easier to test, and also i'm not currently sure that we can just update this atm without chagnes in the builds for launchpad, so i gotta research that as well

You don't have to check every language file, they are all automatically built following the same way. You just have to check one, and files like meson.build. I already tried with French translations and this is working well. I also checked if the desktop and appdata files were translated and they are too.

What do you mean with Launchpad?

NathanBnm commented 5 years ago

EDIT : I updated the post_install.py script to make it better and I made it executable to avoid building issues during deb-packaging, especially with Travis CI.

I removed empty translations files too. Now there's only updated existing translations and French translations that I added (including extra translations, French only).

This should make this PR more comfortable for you to review :smile:

NathanBnm commented 5 years ago

Hi! Any updates here?

Philip-Scott commented 5 years ago

Hi, I'm currently afk for the next couple of weeks. I will check it out soon

NathanBnm commented 4 years ago

@Philip-Scott I resolved conflicts. Could you please take another look. It works fine on my side.

NathanBnm commented 4 years ago

@Philip-Scott any news about this?

Philip-Scott commented 2 years ago

Closing in favor of #385 :)