PhilipJonasFranz / Shelly-PDU

A remote power monitoring tool building on Shelly Plug S smart switches.
Apache License 2.0
15 stars 1 forks source link

ARM64 support #2

Open dominch opened 2 weeks ago

dominch commented 2 weeks ago

hello, this app would be awesome on ARM64 devices like pi5 or anything based on RK3588, I checked this briefly, there was a problem with frontend/Dockerfile,

#RUN apt-get install -y curl git wget unzip libgconf-2-4 gdb libstdc++6 libglu1-mesa fonts-droid-fallback lib32stdc++6 python3 sed
RUN apt-get install -y curl git wget unzip libgconf-2-4 gdb libglu1-mesa fonts-droid-fallback python3 sed

libstdc++6 is already installed as higher version (12 AFAIR) and conflicts with this lib. Without it (second line) all seems to build correctly. are those libs needed at those versions?

BTW: would be nice to build multi-arch image and just download those from dockerhub or anything like this

PhilipJonasFranz commented 2 weeks ago

Hi,

I haven't tested ARM builds yet, but if it builds correctly that's great news. I have a raspberry pi laying around, so I could try to verify that it works.

Regarding Dockerhub and Multi-Arch, I can look into it, but since I'm currently studying for exams, this won't be a priority for some weeks.

If you have a working solution, feel free to open a PR.

dominch commented 2 weeks ago

I was not sure if lib32stdc++6 and libstdc++6 was used for some good purpose, but, for sure ARM version already has +12 version and with those two removed it just build up,

PhilipJonasFranz commented 1 week ago

Thank you for your investigation. I will verify that everything builds with the adjustments and will change the Dockerfile accordingly.