PhilipK / BoilR

Synchronize games from other platforms into your Steam library
Apache License 2.0
1.44k stars 42 forks source link

Non-Steam Games installed to Lutris do not show in Boilr #184

Open Bboy486 opened 2 years ago

Bboy486 commented 2 years ago

As the title says I have installed 2 games from exes in Lutris. They show in Lutris but when I try to see them as a sync option they don't show (actually none of the Lutris games show).

I'm using the Flatpak version of Boilr.

NightHammer1000 commented 2 years ago

Is Lutris running in the Background?

Bboy486 commented 2 years ago

Nope

On Sun, Jul 17, 2022, 1:20 AM Daniel Hirt @.***> wrote:

Is Lutris running in the Background?

— Reply to this email directly, view it on GitHub https://github.com/PhilipK/BoilR/issues/184#issuecomment-1186442873, or unsubscribe https://github.com/notifications/unsubscribe-auth/AD53IKOBY5ARRXXVG2STENLVUO66TANCNFSM53YQ4D3A . You are receiving this because you authored the thread.Message ID: @.***>

PhilipK commented 2 years ago

Just to make sure I understand, the problem is that NO games show up from Lutris? Is this on steam deck? Both BoilR and Lutris are flatpaks?

KaspianDev commented 2 years ago

for me boilr doesnt detect lutris (both flatpaks)

vzarytovskii commented 2 years ago

Same here for me, installed a GOG game in lutris on steam deck, it doesn't show up in boilr.

Both boilr and lutris are flatpaks, lutris is set up as flatpack in boilr's settings.

Heroic and itch.io are working without problems.

Can I somehow provide more diagnostics, if it will help?

PhilipK commented 2 years ago

Can someone who has this problem try to run the following command in a terminal/konsole and post the output?

flatpak run net.lutris.Lutris//beta -lo

That command is what BoilR fires to find which Lutris games are installed (when Lutris is installed through a flatpak).

PhilipK commented 2 years ago

Hmm, I have a bad feeling that this might be a sandboxing issue. When BoilR is run through flatpak it is sandboxed, and that sandbox might not have permissions to query other flatpaks

PhilipK commented 2 years ago

Can someone with this problem try to download the linux executable version and see if Lutris games are picked up then?

PhilipK commented 2 years ago

Yup, this is a p̶r̶o̶b̶l̶e̶m̶ limitation with flatpak in general https://github.com/flatpak/flatpak/issues/4046

I guess the only workaround is to use the linux executable at the moment, or we have to find another way of identifying games installed through lutris.

lal12 commented 2 years ago

I researched that a bit and it seems it should be possible doing this with flatpak-spawn. It seems lutris is doing something similar. The linked issue https://github.com/flatpak/flatpak/issues/4046 seems to refer to a more special case where they need to (un)install flatpak apps, which isn't the case here.

It seems lutris uses the following permissions for that: https://github.com/flathub/net.lutris.Lutris/commit/b4297846e42ff1e972faae7c0d58d5e6a2c17b83

I am trying to try that out, though I am not really familiar with rust...

lal12 commented 2 years ago

@PhilipK Ok it works when I do (in lutris_platform.rs):

let mut command = Command::new("flatpak-spawn");
command.arg("--host").arg("flatpak").arg("run").arg(flatpak_image).arg("-lo").arg("--json").output()?

And adding

  - --talk-name=org.freedesktop.Flatpak
  - --filesystem=xdg-data/flatpak:ro

in flatpak/io.github.philipk.boilr.yml.

I guess doing this only for lutris isn't that useful. Probably that should be integrated in a Command wrapper module and autodetect if ran inside a flatpak sandbox, so it is used for other commands too?

I doubt I could get that done in reasonable time, since I never used rust before. And the code/build/debug cycle with flatpak is quite long.

PhilipK commented 2 years ago

Great find! I am thinking that I will just make a Rust feature, and then build with that feature enabled when building for flatpak. That way there is no need to "autodetect" anything.

I will get right to it.

PhilipK commented 2 years ago

I have pushed a new version of BoilR flatpak now. Hopefully it should work there as well. https://buildbot.flathub.org/#/builders/32/builds/107279

PhilipK commented 2 years ago

Just tested on my own steam deck, and it was able to find lutris with the newest version.

lal12 commented 2 years ago

Works on my arch notebook. ~Though not on my steam deck, still debugging why...~ And on my steam deck, but if I launched lutris I have to reboot before Boilr will detect lutris games again.

lal12 commented 2 years ago

Just wondering shouldn't the same flatpak-spawn should be prepended to all commands called? E.G. legendary.

The README should probably be updated about the Lutris flatpak compatibility. I also noticed that lutris (at least in the flatpak variant) won't give output with -lo --json while running, so a notice about having to close that before running boilr would be helpful too. (README and Settings or Search View)

nabel0 commented 2 years ago

Just tested on my own steam deck, and it was able to find lutris with the newest version.

Hi...BoilR isnt showing my Lutris Games on the Steamdeck. What should i put in in the field i marked in my screenshot to get it to work? 2022-09-01 09_08_15-359 791 067 - AnyDesk

PhilipK commented 2 years ago
  1. make sure that you have the newest version of BoilR

  2. Make sure lutris is shut down

On Thu, Sep 1, 2022, 09:09 nabelo @.***> wrote:

Just tested on my own steam deck, and it was able to find lutris with the newest version.

Hi...BoilR isnt showing my Lutris Games on the Steamdeck. What should i put in in this files to get it to work? [image: 2022-09-01 09_08_15-359 791 067 - AnyDesk] https://user-images.githubusercontent.com/50377455/187853546-87465228-276c-4f00-95a6-e46bb095cc88.png

— Reply to this email directly, view it on GitHub https://github.com/PhilipK/BoilR/issues/184#issuecomment-1233841960, or unsubscribe https://github.com/notifications/unsubscribe-auth/AAEE7DCOBFIRNJYFXLHEUETV4BJDZANCNFSM53YQ4D3A . You are receiving this because you modified the open/close state.Message ID: @.***>

lal12 commented 2 years ago

@nabel0 as I wrote above, for me it only works if I never started Lutris after the last reboot. So maybe do a reboot and try again.

nabel0 commented 2 years ago
  1. make sure that you have the newest version of BoilR 2. Make sure lutris is shut down On Thu, Sep 1, 2022, 09:09 nabelo @.> wrote: Just tested on my own steam deck, and it was able to find lutris with the newest version. Hi...BoilR isnt showing my Lutris Games on the Steamdeck. What should i put in in this files to get it to work? [image: 2022-09-01 09_08_15-359 791 067 - AnyDesk] https://user-images.githubusercontent.com/50377455/187853546-87465228-276c-4f00-95a6-e46bb095cc88.png — Reply to this email directly, view it on GitHub <#184 (comment)>, or unsubscribe https://github.com/notifications/unsubscribe-auth/AAEE7DCOBFIRNJYFXLHEUETV4BJDZANCNFSM53YQ4D3A . You are receiving this because you modified the open/close state.Message ID: @.>

Latest Flatpak update is installed and lutris is also shut down. Unfortunately Boilr isn Showing any of my Lutris Installed Games.

Is "net.lutris.Lutris" the correct configuration in the field i marked in my screenshot? Or do i have to pu something else in this field?

nabel0 commented 2 years ago

@nabel0 as I wrote above, for me it only works if I never started Lutris after the last reboot. So maybe do a reboot and try again.

What did you put in the field i marked in my sreenshot?

nabel0 commented 2 years ago

After a complete reboot it works...thnx

Bboy486 commented 2 years ago

Looks like the flatpak version of lutris is the one that works.

EllAyling commented 2 years ago

I can't get Lutris games to show at all. I am using the flatpak version of Lutris, and the standalone version of Boilr. Have also tried the flatpak version of Boilr and that also doesn't work. Have tried restarting and launching Boilr before doing anything else, and it still doesn't find anything. Having the same issue if I try via Bottles (flatpak). Heroic works fine though (also flatpak).

jacoboqc commented 2 years ago

Hi @PhilipK I also can't get this to work. Using both flatpaks (boilr and lutris), with boilr pointing to the net.lutris.Lutris image, and boilr has permissions to access both the directories where Lutris stores its config and the prefixes. Also tried restarting and loading boilr before lutris. It still cannot find any games from Lutris. Is there any way to get logs from boilr to know what is happening under the hood and try to pinpoint the error?

PhilipK commented 2 years ago

If you run the native version of Boilr it prints its log to the terminal.

On Mon, Oct 17, 2022, 15:39 Jacobo Quintáns @.***> wrote:

Hi @PhilipK https://github.com/PhilipK I also can't get this to work. Using both flatpaks (boilr and lutris), with boilr pointing to the net.lutris.Lutris image, and boilr has permissions to access both the directories where Lutris stores its config and the prefixes. Also tried restarting and loading boilr before lutris. It still cannot find any games from Lutris. Is there any way to get logs from boilr to know what is happening under the hood and try to pinpoint the error?

— Reply to this email directly, view it on GitHub https://github.com/PhilipK/BoilR/issues/184#issuecomment-1280877141, or unsubscribe https://github.com/notifications/unsubscribe-auth/AAEE7DDQCAAW7HCZZGIHLCDWDVJHXANCNFSM53YQ4D3A . You are receiving this because you were mentioned.Message ID: @.***>

jacoboqc commented 2 years ago

Is it possible from the flatpak version?

PhilipK commented 2 years ago

Yes, if you the flatpak from the terminal.

flatpak run io.github.philipk.boilr

jacoboqc commented 2 years ago

It does not show any logs at startup, when it queries Lutris for installed games... BTW this is on steam deck, don't know if it makes a difference

EllAyling commented 2 years ago

Also can't see any output in the console, running via flatpak or otherwise. Tried running with the no-ui option but this just downloads images and then exits. Not sure if I am missing a trick.

samling commented 2 years ago

Like some others above I was having issues with BoilR finding any games under Lutris (currently just a single game installed from ISOs). The combination that finally worked was both flatpak Lutris and BoilR. The flatpak image was set by default to net.lutris.Lutris//beta (possibly from an older version of BoilR?); removing //beta caused my Lutris game to show up. Oddly, it isn't able to detect games from any other launcher, but the non-flatpak BoilR works for that.

Edit: Spoke too soon; returning to Desktop mode and launching flatpak BoilR showed no Lutris games again. Some song and dance of using the non-flatpak BoilR, fixing the Lutris path, and opening/closing Lutris has caused my game to reappear, but I'm not sure yet what the right incantation is to make this work consistently.

PhilipK commented 2 years ago

@samling thanks for the hint with net.lutris.Lutris//beta I can see that the default was actually including the //beta, I have removed that now. It is still a mystery to me why the flatpak version acts this way. BoilR has to break the sandboxing a bit to be allowed to call the Lutris flatpak, so I think it is still related to that. I is a pretty "unsupported" workflow.

Martan404 commented 2 years ago

With the latest BoilR flatpack update I can see my games from Lutris. But I can not see my other flatpack packages if I use BoilR flatpack. If I use BoilR standalone I can see all my flatpacks

lyndonguitar commented 2 years ago

was able to find it a few days ago on a fresh install (just got mine) but now it doesnt find any games now. I wonder what happened? I am using both boilR and Lutris from discover

azafrob commented 2 years ago

Can confirm that since a recent update BoilR is not able to find any Non-Steam game installed through Lutris. Running flatpak run net.lutris.Lutris -lo lists the games correctly.

qnlbnsl commented 1 year ago

@azafrob I can confirm this as well. Boilr and lutris are installed as flatpacks and runningflatpak run net.lutris.Lutris -lo lists the games correctly.